Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner_client: Update default connection port #3642

Merged
merged 1 commit into from
Aug 11, 2022
Merged

miner_client: Update default connection port #3642

merged 1 commit into from
Aug 11, 2022

Conversation

sanlee42
Copy link
Member

@sanlee42 sanlee42 commented Aug 11, 2022 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@sanlee42 sanlee42 enabled auto-merge (squash) August 11, 2022 08:31
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3642 (8cbdc2b) into master (b4f5074) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
- Coverage   28.79%   28.62%   -0.17%     
==========================================
  Files         591      591              
  Lines       50600    50600              
  Branches    23858    23858              
==========================================
- Hits        14566    14478      -88     
- Misses      21846    21901      +55     
- Partials    14188    14221      +33
Flag Coverage Δ
unittests 28.62% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sync/src/block_connector/test_write_block_chain.rs 23.26% <0.00%> (-8.52%) ⬇️
types/src/account_state.rs 56.67% <0.00%> (-6.66%) ⬇️
commons/accumulator/src/tree.rs 50.45% <0.00%> (-5.75%) ⬇️
storage/src/block/mod.rs 51.79% <0.00%> (-4.16%) ⬇️
vm/types/src/token/token_value.rs 55.56% <0.00%> (-4.16%) ⬇️
config/src/helper.rs 41.18% <0.00%> (-3.92%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 37.94% <0.00%> (-3.44%) ⬇️
config/src/account_provider_config.rs 25.40% <0.00%> (-3.17%) ⬇️
sync/src/block_connector/write_block_chain.rs 26.16% <0.00%> (-3.07%) ⬇️
storage/src/lib.rs 53.95% <0.00%> (-2.48%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f5074...8cbdc2b. Read the comment docs.

@sanlee42 sanlee42 changed the title miner_client: Update default cnnection port miner_client: Update default connection port Aug 11, 2022
@github-actions
Copy link

Benchmark for 48afc22

Click to view benchmark
Test Base PR %
accumulator_append 607.1±27.80µs 608.5±30.53µs +0.23%
block_apply/block_apply_10 634.4±2.37ms 634.8±1.87ms +0.06%
block_apply/block_apply_1000 64.6±0.21s 64.7±0.03s +0.15%
get_with_proof/db_store 37.0±0.30µs 36.7±0.26µs -0.81%
get_with_proof/mem_store 31.8±0.49µs 31.4±0.22µs -1.26%
put_and_commit/db_store/1 95.3±4.86µs 96.7±5.01µs +1.47%
put_and_commit/db_store/10 858.1±39.89µs 858.3±38.68µs +0.02%
put_and_commit/db_store/100 7.3±0.30ms 7.4±0.33ms +1.37%
put_and_commit/db_store/5 440.4±21.99µs 440.3±21.55µs -0.02%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 62.1±5.76µs 61.8±5.67µs -0.48%
put_and_commit/mem_store/10 578.0±47.81µs 581.9±49.00µs +0.67%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 292.3±25.02µs 293.2±25.39µs +0.31%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 5.5±0.18ms 5.4±0.18ms -1.82%
query_block/query_block_in(10)_times(1000) 54.7±0.97ms 53.7±2.01ms -1.83%
query_block/query_block_in(10)_times(10000) 546.6±18.13ms 544.3±16.75ms -0.42%
query_block/query_block_in(1000)_times(100) 989.5±5.91µs 1021.3±14.28µs +3.21%
query_block/query_block_in(1000)_times(1000) 9.9±0.10ms 10.2±0.08ms +3.03%
query_block/query_block_in(1000)_times(10000) 99.2±0.53ms 100.5±0.54ms +1.31%
storage_transaction 1072.7±270.32µs 1109.8±347.85µs +3.46%
vm/transaction_execution/1 708.9±2.79ms 710.0±1.25ms +0.16%
vm/transaction_execution/10 176.5±0.44ms 177.3±0.57ms +0.45%
vm/transaction_execution/20 152.0±0.49ms 152.9±0.37ms +0.59%
vm/transaction_execution/5 233.2±0.53ms 234.3±0.98ms +0.47%
vm/transaction_execution/50 166.4±0.42ms 166.7±0.23ms +0.18%

@sanlee42 sanlee42 merged commit 098adf0 into master Aug 11, 2022
@sanlee42 sanlee42 deleted the fix_port branch August 11, 2022 10:52
This was referenced Aug 11, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yourmoonlight yourmoonlight yourmoonlight approved these changes

@jolestar jolestar jolestar approved these changes

@templexxx templexxx Awaiting requested review from templexxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanlee42 @jolestar @yourmoonlight